Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paddlepaddle avg pool3d #22624

Closed
wants to merge 6 commits into from
Closed

Paddlepaddle avg pool3d #22624

wants to merge 6 commits into from

Conversation

KaylaMLe
Copy link

This is a subtask of #15055.

Related Issue

Close #22597

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 26, 2023
@JPGoodale
Copy link
Contributor

JPGoodale commented Sep 3, 2023

Hi @KaylaMLe, it looks like there is an issue with your test args as all tests are currently returning:

E   hypothesis.errors.InvalidArgument: test_paddle_avg_pool3d() got an unexpected keyword argument 'dtype_x_k_s', from dtype_x_k_s=arrays_for_pooling(min_dims=4, max_dims=4, min_side=2, max_side=4) in @given

@KaylaMLe
Copy link
Author

KaylaMLe commented Sep 3, 2023

Ah, okay. That's the test I tried to add, so that makes sense. Are those more specific error messages available in GitHub or only when you run the test locally? From my end, all I could tell were that some number of seemingly random tests were failing, and I couldn't find the error message

@KaylaMLe
Copy link
Author

KaylaMLe commented Sep 3, 2023

I had been trying to set up local testing for a while, but I was having issues with getting Docker to run with PyCharm. I've followed the tutorial, and I'm trying to run the tests by clicking the green button, but I'm getting a directory not found error for a test directory that definitely exists

@JPGoodale
Copy link
Contributor

@KaylaMLe those errors were from running locally. As for your Docker/PyCharm setup issues, if you check out the PyCharm channel on the Ivy discord, I believe that others have faced this issue as well and offered some solutions.

@KaylaMLe
Copy link
Author

KaylaMLe commented Sep 3, 2023

Thanks. There's a pinned comment about adding package paths to the interpreter which may be causing the issue, but the UI I see in PyCharm is different from the screenshot. I'm currently asking about it in that channel.

@KaylaMLe KaylaMLe mentioned this pull request Sep 6, 2023
@JPGoodale
Copy link
Contributor

Hi @KaylaMLe, any luck on getting the tests set up in PyCharm?

@KaylaMLe
Copy link
Author

KaylaMLe commented Oct 2, 2023

Thanks for following up on this. Unfortunately, I still haven't been able to work out the testing issues. I'm also still unsure why my PR is failing. Someone else also got a PR in for this subtask before it was marked as in progress, and AFAIK their PR is also failing. It may be best at this point to close the PR given that I haven't been able to make progress for so long.

@KaylaMLe KaylaMLe closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avg_pool3d
3 participants